Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

83 json dne exception #84

Merged
merged 4 commits into from
Aug 14, 2024
Merged

83 json dne exception #84

merged 4 commits into from
Aug 14, 2024

Conversation

BrianMichell
Copy link
Collaborator

@BrianMichell BrianMichell commented Aug 8, 2024

Resolves #83

  • nlohmann::json::parse has been disallowed to throw internally. Internal cases where it would have thrown an exception will now return an appropriate mdio::Result.

@BrianMichell BrianMichell added the bug Something isn't working label Aug 8, 2024
Copy link
Collaborator

@markspec markspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrianMichell BrianMichell merged commit adf7aa0 into main Aug 14, 2024
6 checks passed
@BrianMichell BrianMichell deleted the 83_json_DNE_exception branch August 14, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle throwing an instance of 'nlohmann::json_abi_v3_11_3::detail::parse_error'
2 participants